Fix missing transaction commit for multi-tenanted EF Core #2041
+98
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerfectlyNormal
force-pushed
the
fix/ef-transaction
branch
from
5097375 to
ae399cc
Compare
Member
|
@PerfectlyNormal I just added the new idempotency check. Need to also add the new domain event scraping to the multi-tenancy path. Missed that when I was adding it before. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2040, at least in my test and the repro project
This should probably get a thorough review, as I feel I'm deeper in Wolverine than I should be and this could possibly affect other things. Feels a bit like a "works on my machine, now you try".
Mostly copied from
EnrollDbContextInTransaction, but without theIDomainEventScraperbits. Started to look into it, but a bit unsure how it should work